Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header button has no effect #665

Closed
benbro opened this issue May 15, 2016 · 6 comments
Closed

Header button has no effect #665

benbro opened this issue May 15, 2016 · 6 comments

Comments

@benbro
Copy link
Contributor

benbro commented May 15, 2016

Can't change a line to h1
Text align button has similar issue.

Steps for Reproduction

  1. Visit http://beta.quilljs.com/
  2. Select some text
  3. Click on the header button and choose 'Heading'.

Expected behavior:
The selected paragraph should switch to <h1>

Actual behavior:
Heading isn't set.
The editor loses focus.

Platforms:
Firefox 46 on Windows 7

Version:
1.0-Beta.2

@jhchen
Copy link
Member

jhchen commented May 16, 2016

I'm having troubling reproducing this on FF46/Win8.1. Can you include the specific text you are selecting before trying to apply the heading?

header

@benbro
Copy link
Contributor Author

benbro commented May 16, 2016

No matter what text I'm selecting it has no effect.
I've tried selecting the same text as you (WYSIWYG) and the heading button does nothing.
Tested with Firefox 46 and Chrome 50 on Windows 7.

Not sure why it work for you but not for me.
Can someone else try to reproduce?

@benbro
Copy link
Contributor Author

benbro commented May 17, 2016

Screen capture of the issue
https://drive.google.com/file/d/0B12AhxvnYHrAWDJfT2Vza1ItMkk/view

Firefox 46 on Ubuntu 16.04

@mgkirs
Copy link

mgkirs commented May 18, 2016

I can reproducing this bug on Google Chrome and Firefox (Fedora x64)

i think bug in toolbar button events. if i clicked very fast editor working. But if i do onmousedown on the button, button disappears, mouse doing onmosemove on other element, focus lost, and i cant do onmouseup on the button and doing onmouseup on different element

@jhchen
Copy link
Member

jhchen commented May 18, 2016

Thanks for the insight @mgkirs. Another commit seems to have already fixed this on the 1.0 branch. @benbro can you confirm on beta.quilljs.com. I updated it with a new build so in the console Quill.version should return "1.0.0-beta.2-5aa302" now.

@benbro
Copy link
Contributor Author

benbro commented May 18, 2016

Working now on beta.quilljs.com
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants