Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag <button> in buttons submit form #685 #685

Closed
mgkirs opened this issue May 19, 2016 · 3 comments
Closed

tag <button> in buttons submit form #685 #685

mgkirs opened this issue May 19, 2016 · 3 comments

Comments

@mgkirs
Copy link

mgkirs commented May 19, 2016

unfinished events

Steps for Reproduction

  1. http://codepen.io/anon/pen/jqjGMv
  2. read first html line:
  3. click on image-tooltip button

Expected behavior: change image url;

Actual behavior: submit form whith "#contenttm" textarea element only

Platforms: Chrome 50 on Fedora x64

Version: 1.0.0-beta.2-5aa302

its real #665

@mgkirs mgkirs changed the title #665 events can submit form #665 May 19, 2016
@mgkirs
Copy link
Author

mgkirs commented May 19, 2016

fix work, but why thats submit form...

@mgkirs mgkirs mentioned this issue May 20, 2016
@mgkirs
Copy link
Author

mgkirs commented May 21, 2016

quill use tag <button>on buttons and this can submit form whith out javascript events

@mgkirs mgkirs changed the title events can submit form #665 tag <button> in buttons submit form #685 May 21, 2016
@mgkirs mgkirs mentioned this issue May 21, 2016
@jhchen
Copy link
Member

jhchen commented May 23, 2016

I'll update Quill to generate s with type=button but since in the example you are supplying the toolbar element and creating it in HTML, you need to add this attribute yourself.

@jhchen jhchen closed this as completed May 23, 2016
@jhchen jhchen mentioned this issue May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants