You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you insert a new character right before the same existing character, Quill incorrectly creates a Delta suggesting that the existing character was added, not the new character.
While this technically results in the same document, it does result in certain issues. For example, when I'm trying to re-implement MultiCursor support, it's resulting in shiftCursors() not moving the cursor to the new correct position since the generated delta incorrectly indicates which character was added. This will also ultimately create issues for the authorship module as well on exactly who inserted what character.
This was in place because the issue of misplaced deltas regarding the
edit position when adding characters to a character sequence, because of
the diff strategy of the fast-diff lib detailed on this issue/PR,
slab/quill#746.
Since this has been fixed on fast-diff at
jhchen/fast-diff#2,
the loopback fix/workaround is no longer necessary.
When you insert a new character right before the same existing character, Quill incorrectly creates a Delta suggesting that the existing character was added, not the new character.
While this technically results in the same document, it does result in certain issues. For example, when I'm trying to re-implement MultiCursor support, it's resulting in shiftCursors() not moving the cursor to the new correct position since the generated delta incorrectly indicates which character was added. This will also ultimately create issues for the authorship module as well on exactly who inserted what character.
Steps for Reproduction
Expected behavior:
Console shows that the generated Delta is simply: [{insert: "t"}]
Actual behavior:
Actual generated delta is: [{retain: 2}, {insert: "t"}]
Platforms:
Chrome 51 on Mac 10.11
Version:
Quill 1.0 Beta 4
The text was updated successfully, but these errors were encountered: