Correctly convert mixed lists #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
convert-mixed-lists
branch
from
f23a206
to
7ba652e
Compare
At the moment, it's possible to construct a "mixed" list of ordered and bulleted items, eg: ```markdown 1. One 2. Two - Foo - Bar ``` If you create this list in Quill, then cut it and paste it back again, the bullet items are transformed into ordered items, which is surprising. This change updates the list HTML conversion logic to check that the list is still a continuation of the previous type. If not, it starts a new list of the correct type.
alecgibson
force-pushed
the
convert-mixed-lists
branch
from
7ba652e
to
f4f4793
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, it's possible to construct a "mixed" list of ordered and
bulleted items, eg:
If you create this list in Quill, then cut it and paste it back again,
the bullet items are transformed into ordered items, which is
surprising.
This change updates the list HTML conversion logic to check that the
list is still a continuation of the previous type. If not, it starts a
new list of the correct type.