Ignore whitespace between pasted empty paragraphs #3480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
is-line-fix
branch
from
4789461 to
47c08a3
Compare
At the moment, when pasting HTML containing empty paragraphs with whitespace between them, the whitespace is incorrectly rendered. For example: ```html <p></p> <p></p> ``` will result in a Delta containing `' \n'` This happens because the clipboard's `isLine()` function assumes that any element without children is an embed (which isn't true for things like empty paragraphs). This change updates the `isLine()` check to check the node against the registry, and see if we have a matching `EmbedBlot` there.
|
Thanks for the contribution! Had to reimplement it due to code conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when pasting HTML containing empty paragraphs with
whitespace between them, the whitespace is incorrectly rendered.
For example:
will result in a Delta containing
' \n'This happens because the clipboard's
isLine()function assumes thatany element without children is an embed (which isn't true for things
like empty paragraphs).
This change updates the
isLine()check to check the node against theregistry, and see if we have a matching
EmbedBlotthere.