New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take care to not modify deltas in place when composing in undo-manager #387

Closed

thomsbg wants to merge 1 commit into slab:develop from voxmedia:fix-undo-manager

+2 −2

Contributor

thomsbg commented Jun 2, 2015

Fixes #296


          Take care to not modify deltas in place when composing in undo-manager,

d32cc16

fixes slab#296

jhchen reviewed

View reviewed changes

src/modules/undo-manager.coffee

    
            @@ -51,8 +51,8 @@ class UndoManager
          
                    timestamp = new Date().getTime()

                    if @lastRecorded + @options.delay > timestamp and @stack.undo.length > 0

                      change = @stack.undo.pop()

                      undoDelta = undoDelta.compose(change.undo)

                      changeDelta = change.redo.compose(changeDelta)

                      undoDelta = new Delta().compose(undoDelta).compose(change.undo)

Member

jhchen Jun 3, 2015

This works but might be more clear to use slice(). Passing no parameters will create a copy.

thomsbg closed this

thomsbg deleted the fix-undo-manager branch

December 28, 2016 21:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet