Fix typing errors for Quill.register #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzgotb
force-pushed
the
perf-quill-register
branch
from
6d92a98
to
7e46419
Compare
luin
reviewed
Apr 30, 2024
packages/quill/src/core/quill.ts
Outdated
| type RegistryTarget = Parchment.RegistryDefinition | Module | boolean; | ||
|
|
||
| interface RegistryRecord { | ||
| [key: `blots/${string}`]: Parchment.BlotConstructor; |
There was a problem hiding this comment.
Would this improve the type safety? The following code still passes:
Quill.register({
'blots/abc': 'abc'
});
hzgotb
force-pushed
the
perf-quill-register
branch
from
7e46419
to
4beca86
Compare
Closed
hzgotb
force-pushed
the
perf-quill-register
branch
from
4beca86
to
bb079b2
Compare
luin
force-pushed
the
perf-quill-register
branch
2 times, most recently
from
2e59f38
to
7d9ed76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.