Improve typings for methods that return a Delta #4136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my current quill version:
v2.0.0
.as in v2, quill provides its own bundled dts file for developers, but some methods under the
Quill
scope are incorrectly typed due toFunction.call()
will returns anany
type.e.g.,
quill.updateContents()
, its return type should beDelta
, but in quill.d.ts, the signature isthis pr solves the problem by explicitly declaring the return type, and improve dts type tests