Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keyboard accessibility for multiple Quill instances #439

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

kmoe
Copy link
Contributor

@kmoe kmoe commented Aug 7, 2015

When there are multiple Quill instances on a page (for example, a form that needs to be filled in with rich text data) and you have disabled tab using the technique in #110, it takes about 6 hits of the tab key to get from one field to the next.

This is due to the extra keyboard-focusable elements in the paste manager and tooltip modules.

Solution: add tabindex="-1" to these elements so they are skipped when tabbing through the page.

This also solves numerous problems with screenreaders not automatically reading down the page.

@jhchen
Copy link
Member

jhchen commented Aug 8, 2015

I think making the paste-manager not tab-able makes sense. The tooltips both have a template so they're already customizable so it's not clear they need to have this markup by default as well. There should be a push for better accessibility and interoperability with screenreaders but that should be a separate issue where aria attributes are also properly set.

@kmoe
Copy link
Contributor Author

kmoe commented Aug 10, 2015

Sure, I'll change this PR so it only sets the tabindex on paste-manager, and do some more investigation on screen reader issues (the app I'm using Quill in aims to be WCAG 2.0 compliant so I'll need to solve this problem at some point).

@kmoe kmoe force-pushed the keyboard-accessibility branch from 88077c0 to 3362eaa Compare August 10, 2015 11:13
@kmoe
Copy link
Contributor Author

kmoe commented Aug 10, 2015

Done.

jhchen added a commit that referenced this pull request Aug 12, 2015
Prevent tabbing into paste container
@jhchen jhchen merged commit 03c9416 into slab:develop Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants