Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slack Edge Package #7

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Update Slack Edge Package #7

merged 3 commits into from
Dec 26, 2023

Conversation

zhawtof
Copy link
Contributor

@zhawtof zhawtof commented Dec 25, 2023

Changes:

  • Updated Slack Edge Packages
  • Moved all imports to slack-edge

Open Questions:

There are imports from slack-web-api-client but this library is not a dependency in package.json. It seemed there are two choices:

  1. add the package
  2. remove the imports and funnel through slack-edge since that also exports these files

I went with (2) but let me know if (1) is a better choice.

@seratch seratch added the dependencies Pull requests that update a dependency file label Dec 26, 2023
seratch
seratch approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This change looks good to me

@seratch seratch merged commit 4508c3d into slack-edge:main Dec 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhawtof @seratch