Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for status_emoji_display_info #1120

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add support for status_emoji_display_info #1120

merged 1 commit into from
Nov 4, 2022

Conversation

paultyng
Copy link
Contributor

@paultyng paultyng commented Oct 31, 2022 •
edited
Loading

Add missing field to users.profile.get, status_emoji_display_info which is a list of all the emoji's present in the status emoji or status text and details about them.

Here is an example response:

{
    "ok": true,
    "profile": {
        ...
        "status_text": "Construction!",
        "status_emoji": ":construction:",
        "status_emoji_display_info": [
            {
                "emoji_name": "construction",
                "unicode": "1f6a7",
                "display_url": "https://a.slack-edge.com/production-standard-emoji-assets/14.0/apple-large/1f6a7.png"
            }
        ],
        "status_expiration": 0,
        ...
       }
}

kanata2
kanata2 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I'll merge this after confirming actual response on my end.

users.go
Comment on lines +47 to 52
type UserProfileStatusEmojiDisplayInfo struct {
EmojiName string `json:"emoji_name"`
DisplayAlias string `json:"display_alias,omitempty"`
DisplayURL string `json:"display_url,omitempty"`
Unicode string `json:"unicode,omitempty"`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[review memo]
java sdk's definition: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-model/src/main/java/com/slack/api/model/User.java#L118-L122

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unicode is new, I just added it (I'm an eng at Slack)

@kanata2 kanata2 added enhancement spec undocumented Slack does not document yet labels Oct 31, 2022
@paultyng paultyng mentioned this pull request Nov 2, 2022
Closed
@kanata2 kanata2 merged commit df7caaf into slack-go:master Nov 4, 2022
@paultyng paultyng deleted the status_emoji_display_info branch November 4, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
enhancement spec undocumented Slack does not document yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paultyng @kanata2