Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add block elements for email_text_input and url_text_input #1140

Merged
merged 4 commits into from
Dec 10, 2022
Merged

add block elements for email_text_input and url_text_input #1140

merged 4 commits into from
Dec 10, 2022

Conversation

ameliagapin
Copy link
Contributor

Adds email_text_input and url_text_input block elements, which were recently added to BlockKit, to the SDK.

I tested these by using them in a modal:
Screenshot 2022-11-30 at 9 51 11 AM

And the values in the request from Slack:
Screenshot 2022-11-30 at 9 52 14 AM

@kanata2 kanata2 self-requested a review December 2, 2022 18:36
kanata2
kanata2 reviewed Dec 7, 2022
View reviewed changes
block_element_test.go Outdated Show resolved Hide resolved
kanata2
kanata2 requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. I commented on a couple of minor points.

kanata2
kanata2 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kanata2 kanata2 merged commit c857464 into slack-go:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameliagapin @kanata2