fix: change period to comma #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanata2
reviewed
Dec 20, 2022
| Style *RichTextSectionTextStyle `json:"style.omitempty"` | ||
| Style *RichTextSectionTextStyle `json:"style,omitempty"` |
block_rich_text.go
Outdated
Comment on lines
321
to
322
| func NewRichTextSectionUserGroupElement(usergroupID string) *RichTextSectionUserGroupElement { | ||
| func NewRichTextSectionUserGroupElement(usergroupID string, style *RichTextSectionTextStyle) *RichTextSectionUserGroupElement { |
There was a problem hiding this comment.
This breaks backward-compatibility, so if you want to use this immediately, maybe divide this PR into another one.
There was a problem hiding this comment.
(If there is nothing wrong with including next minor release, you don't divide.)
There was a problem hiding this comment.
Thanks for the review.
You are right about breaking backward compatibility. This PR should only be a comma modification of omitempty, and the style addition changes should be created as a new separate PR.
There was a problem hiding this comment.
PR was changed to comma change only.
The title and description of the PR have also been changed.
yokishava
changed the title
kanata2
added
api cleanup
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The character before omitempty in the RichTextSectionElement struct tag was period.
What
I changed to comma.