Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slice replace loop #1211

Merged
merged 2 commits into from
Jul 15, 2024
Merged

chore: slice replace loop #1211

merged 2 commits into from
Jul 15, 2024

Conversation

testwill
Copy link
Contributor

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

Copy link
Contributor

@lorenzoaiello lorenzoaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @testwill !

Non-functional change that simplifies the code. A quick glance through the codebase shows that there may be other instances of this that can also be cleaned up, but this is a good start.

@lorenzoaiello lorenzoaiello merged commit f7cac82 into slack-go:master Jul 15, 2024
4 checks passed
renovate bot added a commit to validator-labs/validator that referenced this pull request Jul 16, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/slack-go/slack](https://togithub.com/slack-go/slack) |
`v0.13.0` -> `v0.13.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>slack-go/slack (github.com/slack-go/slack)</summary>

###
[`v0.13.1`](https://togithub.com/slack-go/slack/releases/tag/v0.13.1)

[Compare
Source](https://togithub.com/slack-go/slack/compare/v0.13.0...v0.13.1)

#### What's Changed

v0.13.1 is now available. It contains **no breaking changes** but does
expose some new fields previously unavailable.

##### Enhancements

- Added `UnfurlLinks` and `UnfurlMedia` to `WebhookMessage` by
[@&#8203;lheiskan](https://togithub.com/lheiskan) in
[slack-go/slack#1208
- Added `isReadOnly` property to `Conversation` struct by
[@&#8203;GGonryun](https://togithub.com/GGonryun) in
[slack-go/slack#1232

##### Bug Fixes

- Fixed `UploadFileV2` when using text content by
[@&#8203;calebmckay](https://togithub.com/calebmckay) in
[slack-go/slack#1291
- Made `Channel` optional on `UploadFileV2` by
[@&#8203;0xdeafcafe](https://togithub.com/0xdeafcafe) in
[slack-go/slack#1293

##### Chores / Code Cleanup

- Replace a Loop with Slice by
[@&#8203;testwill](https://togithub.com/testwill) in
[slack-go/slack#1211
- Added Deprecation Notice for `files.upload` by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1300
- Added Go Test Coverage for 1.21 and 1.22 by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1298

##### Documentation Updates

- Updated Inline Docs and API References by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1299
- Added an example for `Pagination` by
[@&#8203;adamrothman](https://togithub.com/adamrothman) in
[slack-go/slack#1201
- Added an example for `ConversationHistory` by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1302
- Added an example for `AddRemoteFile` and `DeleteFile` by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1303

#### New Contributors

- [@&#8203;calebmckay](https://togithub.com/calebmckay) made their first
contribution in
[slack-go/slack#1291
- [@&#8203;lheiskan](https://togithub.com/lheiskan) made their first
contribution in
[slack-go/slack#1208
- [@&#8203;GGonryun](https://togithub.com/GGonryun) made their first
contribution in
[slack-go/slack#1232
- [@&#8203;0xdeafcafe](https://togithub.com/0xdeafcafe) made their first
contribution in
[slack-go/slack#1293
- [@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) made their
first contribution in
[slack-go/slack#1300
- [@&#8203;adamrothman](https://togithub.com/adamrothman) made their
first contribution in
[slack-go/slack#1201

**Full Changelog**:
slack-go/slack@v0.13.0...v0.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/validator-labs/validator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnbyJdfQ==-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ymotongpoo pushed a commit to ymotongpoo/opentelemetry-collector-extra that referenced this pull request Aug 13, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/slack-go/slack](https://togithub.com/slack-go/slack) |
`v0.13.0` -> `v0.13.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>slack-go/slack (github.com/slack-go/slack)</summary>

###
[`v0.13.1`](https://togithub.com/slack-go/slack/releases/tag/v0.13.1)

[Compare
Source](https://togithub.com/slack-go/slack/compare/v0.13.0...v0.13.1)

#### What's Changed

v0.13.1 is now available. It contains **no breaking changes** but does
expose some new fields previously unavailable.

##### Enhancements

- Added `UnfurlLinks` and `UnfurlMedia` to `WebhookMessage` by
[@&#8203;lheiskan](https://togithub.com/lheiskan) in
[slack-go/slack#1208
- Added `isReadOnly` property to `Conversation` struct by
[@&#8203;GGonryun](https://togithub.com/GGonryun) in
[slack-go/slack#1232

##### Bug Fixes

- Fixed `UploadFileV2` when using text content by
[@&#8203;calebmckay](https://togithub.com/calebmckay) in
[slack-go/slack#1291
- Made `Channel` optional on `UploadFileV2` by
[@&#8203;0xdeafcafe](https://togithub.com/0xdeafcafe) in
[slack-go/slack#1293

##### Chores / Code Cleanup

- Replace a Loop with Slice by
[@&#8203;testwill](https://togithub.com/testwill) in
[slack-go/slack#1211
- Added Deprecation Notice for `files.upload` by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1300
- Added Go Test Coverage for 1.21 and 1.22 by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1298

##### Documentation Updates

- Updated Inline Docs and API References by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1299
- Added an example for `Pagination` by
[@&#8203;adamrothman](https://togithub.com/adamrothman) in
[slack-go/slack#1201
- Added an example for `ConversationHistory` by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1302
- Added an example for `AddRemoteFile` and `DeleteFile` by
[@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) in
[slack-go/slack#1303

#### New Contributors

- [@&#8203;calebmckay](https://togithub.com/calebmckay) made their first
contribution in
[slack-go/slack#1291
- [@&#8203;lheiskan](https://togithub.com/lheiskan) made their first
contribution in
[slack-go/slack#1208
- [@&#8203;GGonryun](https://togithub.com/GGonryun) made their first
contribution in
[slack-go/slack#1232
- [@&#8203;0xdeafcafe](https://togithub.com/0xdeafcafe) made their first
contribution in
[slack-go/slack#1293
- [@&#8203;lorenzoaiello](https://togithub.com/lorenzoaiello) made their
first contribution in
[slack-go/slack#1300
- [@&#8203;adamrothman](https://togithub.com/adamrothman) made their
first contribution in
[slack-go/slack#1201

**Full Changelog**:
slack-go/slack@v0.13.0...v0.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants