expose slackevents.ReactionEvent #1275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzoaiello
added
enhancement
RTM API
lorenzoaiello
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Thanks for the help @kjelle , can you please add a corresponding test for each event type we are now exposing (ReactionAddedEvent and ReactionRemovedEvent)? You can find the other event types tested in inner_events_tests.go` in the same directory as the file you modified.
lorenzoaiello
added
missing test
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This PR is related to #1095 and matthew-graves@a293ed4.
Please accept this PR to expose
slackevents.ReactionEvent