Expose private File Upload V2 methods to support multiple file uploads in a single message #1376
+319
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutoKashiwagi
commented
Feb 19, 2025
Comment on lines
+288
to
+302
| type mockGetUploadURLExternalHttpClient struct { | ||
| ResponseStatus int | ||
| ResponseBody []byte | ||
| } | ||
|
|
||
| func (m *mockGetUploadURLExternalHttpClient) Do(req *http.Request) (*http.Response, error) { | ||
| if req.URL.Path != "files.getUploadURLExternal" { | ||
| return nil, fmt.Errorf("invalid path: %s", req.URL.Path) | ||
| } | ||
|
|
||
| return &http.Response{ | ||
| StatusCode: m.ResponseStatus, | ||
| Body: io.NopCloser(bytes.NewBuffer(m.ResponseBody)), | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
I considered following the existing once.Do(startServer) approach for testing, but found that simply mocking Client.httpclient would be sufficient. Therefore, I decided to mock it instead.
YutoKashiwagi
commented
Feb 19, 2025
Comment on lines
+627
to
+630
| Files: []FileSummary{{ | ||
| ID: u.FileID, | ||
| Title: params.Title, | ||
| }}, |
There was a problem hiding this comment.
For CompleteUploadURLExternal, I've not only made it public but also updated its signature so that multiple fileID parameters (with IDs and titles) can be specified, aligning it more closely with Slack’s official API.
|
thanks for doing this. I just was revisiting a way to grab the urls so I could publish a single "gallery style" message and this probably will fix much of that by providing back the upload urls back. cheers 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for maintaining slack-go!
Currently,
UploadFileV2Contextworks by sequentially calling three private methods in the following flow:Because these methods are private, developers can only upload one file per message via
UploadFileV2Context. However, the Slack API itself supports uploading multiple files in a single message by running these steps for each file and then calling completeUploadURLExternal for all file IDs together.To unlock this functionality while still using slack-go, I’ve made the following changes in this PR:
getUploadURLExternalandcompleteUploadExternalpublicuploadToURLremains private for now. This method is simply a regular POST request handler, not part of Slack’s official API. Since making getUploadURLExternal and completeUploadExternal public already addresses the main use case of uploading multiple files, this might be sufficient.Thank you for considering this proposal. Being able to handle multi-file uploads in a single Slack message through slack-go would be extremely helpful. If you have any suggestions or an alternative approach, I’d love to hear them!
Related Issues
Pull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prepfrom the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: