Support latest version of SlackRubyBot by applying instrumentation to message hook #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstole
force-pushed
the
support_latest_bot
branch
from
6ab829a to
b895538
Compare
dblock
approved these changes
Sep 26, 2017
Gemfile
Outdated
| @@ -2,6 +2,7 @@ source 'http://rubygems.org' | |||
|
|
|||
| gemspec | |||
|
|
|||
| gem 'celluloid-io', require: %w(celluloid/current celluloid/io) | |||
There was a problem hiding this comment.
These should probably be inside a test or development group(s).
newrelic-slack-ruby-bot.gemspec
Outdated
| @@ -14,5 +14,5 @@ Gem::Specification.new do |s| | |||
| s.licenses = ['MIT'] | |||
| s.summary = 'NewRelic instrumentation for slack-ruby-bot.' | |||
| s.add_dependency 'newrelic_rpm' | |||
| s.add_dependency 'slack-ruby-bot', '<= 0.7.0' | |||
| s.add_dependency 'slack-ruby-bot', '> 0.7.0' | |||
There was a problem hiding this comment.
This should be >= the exact version with which it works, so if 0.8.0 was the first one where this change shipped, it should be >= 0.8.0.
kstole
force-pushed
the
support_latest_bot
branch
from
b895538 to
dee7d72
Compare
|
Shall we merge this and then create a new release? |
|
Yup, merged, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, I think we should just apply the instrumentation to the built in message hook and then when the hooks mechanism in SlackRubyBot is updated to use the
onmethod, we can look at changing this. @dblock thoughts?