Name New Relic transactions according to command called #8
Conversation
kstole
force-pushed
the
feature/transaction_naming
branch
from
f48d43b to
b0ca427
Compare
| command_class.class_eval do | ||
| class << self | ||
| def call_command_with_new_relic(client, data, match, block) | ||
| ::NewRelic::Agent.set_transaction_name("#{self}/#{match[:command].downcase}") |
There was a problem hiding this comment.
Why downcase? Because the matching is not case-sensitive?
There was a problem hiding this comment.
New Relic separates transactions by name and is case sensitive. So if someone types @mybot Command it would show up separately from @mybot command. Downcasing normalizes the names so that individual commands are aggregated in New Relic.
|
It looks good. |
kstole
force-pushed
the
feature/transaction_naming
branch
from
b0ca427 to
0c10acb
Compare
|
I added tests and support for matches from |
|
@kstole I added you to slack-ruby-bot (https://github.com/slack-ruby/slack-ruby-bot/invitations), so you can just make that release (follow RELEASING as usual). |
|
Closing and reopening to start new build |
Depends on refactoring in
SlackRubyBot::Commands::Base: slack-ruby/slack-ruby-bot#164This causes transactions in New Relic to be separated by command.
E.g.
MySlackBot::Commands::Authentication/auth