Fix: add missing kaminari-grape dependency and locked roar. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
fix-dependencies
branch
from
76fecab
to
99956dd
Compare
Generated by 🚫 danger |
|
Hey, on this note I found I need gem |
|
Hm, it worked for my bots, but give it a try: remove that dependency in yours and update the dependency on slack-ruby-bot-server that I just released? |
|
Ah, from my I found that if I upgrade representable to 3.x then I get a lot of test failures. I see that the latest roar has a Not sure if we're running into the same issue... IIRC the |
|
Yes, I see the same thing. Didn't debug. |
|
It's on my todo list, but I won't get to it fast btw @swalberg. It would be great if someone (maybe you?) actually dug up what changed in representable to cause this. |
|
I'll see what I can do! |
|
Spent a few minutes with trailblazer/roar@3540c8e broke it in the roar gem, which is where it updates to representable 2.4.0. Will dig into representable next. |
|
The representable problem was fixed in ruby-grape/grape-roar#21, maybe @swalberg wants to give it a shot at upgrading here? |
|
Thanks, I'll give it a shot this weekend. |
|
Yup, it works! |
swalberg
added a commit
to swalberg/slack-ruby-bot-server
that referenced
this pull request
Feb 21, 2017
Fixes compatibility problems with representable 2.4+. An API change meant that the current way of passing in the rack environment was getting clobbered, and we were unable to access the context of the request. See https://github.com/ruby-grape/grape-roar/pull/21/files for the fix and conversation in slack-ruby#43
swalberg
added a commit
to swalberg/slack-ruby-bot-server
that referenced
this pull request
Feb 21, 2017
Fixes compatibility problems with representable 2.4+. An API change meant that the current way of passing in the rack environment was getting clobbered, and we were unable to access the context of the request. See https://github.com/ruby-grape/grape-roar/pull/21/files for the fix and conversation in slack-ruby#43
swalberg
added a commit
to swalberg/slack-ruby-bot-server
that referenced
this pull request
Feb 21, 2017
Fixes compatibility problems with representable 2.4+. An API change meant that the current way of passing in the rack environment was getting clobbered, and we were unable to access the context of the request. See https://github.com/ruby-grape/grape-roar/pull/21/files for the fix and conversation in slack-ruby#43 Change properties to `public` methods See slack-ruby#45 - slack-ruby#45 trailblazer/representable@74155a9 changed to use `public_send` for these types of methods. Use danger format
swalberg
added a commit
to swalberg/slack-ruby-bot-server
that referenced
this pull request
Feb 21, 2017
Fixes compatibility problems with representable 2.4+. An API change meant that the current way of passing in the rack environment was getting clobbered, and we were unable to access the context of the request. See https://github.com/ruby-grape/grape-roar/pull/21/files for the fix and conversation in slack-ruby#43 Change properties to `public` methods See slack-ruby#45 - slack-ruby#45 trailblazer/representable@74155a9 changed to use `public_send` for these types of methods. Use danger format
swalberg
added a commit
to swalberg/slack-ruby-bot-server
that referenced
this pull request
Feb 21, 2017
Fixes compatibility problems with representable 2.4+. An API change meant that the current way of passing in the rack environment was getting clobbered, and we were unable to access the context of the request. See https://github.com/ruby-grape/grape-roar/pull/21/files for the fix and conversation in slack-ruby#43 Change properties to `public` methods See slack-ruby#45 - slack-ruby#45 trailblazer/representable@74155a9 changed to use `public_send` for these types of methods. Use danger format
swalberg
added a commit
to swalberg/slack-ruby-bot-server
that referenced
this pull request
Feb 21, 2017
Fixes compatibility problems with representable 2.4+. An API change meant that the current way of passing in the rack environment was getting clobbered, and we were unable to access the context of the request. See https://github.com/ruby-grape/grape-roar/pull/21/files for the fix and conversation in slack-ruby#43 Change properties to `public` methods See slack-ruby#45 - slack-ruby#45 trailblazer/representable@74155a9 changed to use `public_send` for these types of methods. Use danger format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.