Sample app: include broken dependencies, add instructions #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#47](https://github.com/slack-ruby/slack-ruby-bot-server/pull/47): Sample app: include broken dependencies, add instructions - [@Aupajo](https://github.com/Aupajo).Generated by 🚫 danger |
|
Do you think we could add this to the build? |
|
In fact having this part of the build would be very useful for #7. |
|
@dblock Thanks for replying! I'm not sure what you mean by “Do you think we could add this to the build?” |
|
I'd like Travis-CI to actually run the specs in the sample projects. |
|
Trying to do this in #49. |
|
Closing via #49, I included your docs as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MRI 2.4, the specs inside the sample app were failing due to both
Rack::TestandDatabaseCleanerbeing unavailable. This PR fixes those issues and includes some extra information in the README.