Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to load OTR module is Rails #67

Merged
merged 3 commits into from
Aug 29, 2017
Merged

Conversation

darbyfrey
Copy link
Contributor

otr-activerecord isn't loaded in Rails, so the middleware will fail with uninitialized constant OTR. This change will skip attempting to load OTR::ActiveRecord::ConnectionManagement if OTR is not defined (i.e. in Rails).

@dangerpr-bot
Copy link

dangerpr-bot commented Aug 25, 2017

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Collaborator

dblock commented Aug 25, 2017

Thanks. We do want a changelog entry for this please.

@darbyfrey
Copy link
Contributor Author

@dblock just added an entry to the Changelog.

@darbyfrey
Copy link
Contributor Author

Not sure what's happening with that build failure. Is that a common issue?

@dblock
Copy link
Collaborator

dblock commented Aug 29, 2017

Build failed because One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces. It's missing your name.

@dblock dblock merged commit 8d599bc into slack-ruby:master Aug 29, 2017
@dblock
Copy link
Collaborator

dblock commented Aug 29, 2017

👍

@darbyfrey
Copy link
Contributor Author

Thanks @dblock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants