Fixed RTM example for async.

.rubocop_todo.yml

@@ -1,17 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-08-25 18:15:23 +0200 using RuboCop version 0.58.2.
+# on 2018-08-27 13:21:41 +0200 using RuboCop version 0.58.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'lib/slack/real_time/concurrency/async.rb'
-
 # Offense count: 4
 Lint/HandleExceptions:
   Exclude:

examples/hi_real_time_async_async/hi.rb

@@ -3,33 +3,35 @@
 
 raise 'Missing ENV[SLACK_API_TOKENS]!' unless ENV.key?('SLACK_API_TOKENS')
 
-Async::Reactor.run do
-  $stdout.sync = true
-  logger = Logger.new($stdout)
-  logger.level = Logger::DEBUG
+$stdout.sync = true
+logger = Logger.new($stdout)
+logger.level = Logger::DEBUG
 
-  ENV['SLACK_API_TOKENS'].split.each do |token|
-    logger.info "Starting #{token[0..12]} ..."
+threads = []
 
-    client = Slack::RealTime::Client.new(token: token)
+ENV['SLACK_API_TOKENS'].split.each do |token|
+  logger.info "Starting #{token[0..12]} ..."
 
-    client.on :hello do
-      logger.info "Successfully connected, welcome '#{client.self.name}' to the '#{client.team.name}' team at https://#{client.team.domain}.slack.com."
-    end
+  client = Slack::RealTime::Client.new(token: token)
 
-    client.on :message do |data|
-      logger.info data
+  client.on :hello do
+    logger.info "Successfully connected, welcome '#{client.self.name}' to the '#{client.team.name}' team at https://#{client.team.domain}.slack.com."
+  end
 
-      client.typing channel: data.channel
+  client.on :message do |data|
+    logger.info data
 
-      case data.text
-      when /hi/ then
-        client.message channel: data.channel, text: "Hi <@#{data.user}>!"
-      else
-        client.message channel: data.channel, text: "Sorry <@#{data.user}>, what?"
-      end
-    end
+    client.typing channel: data.channel
 
-    client.start_async
+    case data.text
+    when /hi/ then
+      client.message channel: data.channel, text: "Hi <@#{data.user}>!"
+    else
+      client.message channel: data.channel, text: "Sorry <@#{data.user}>, what?"
+    end
   end
+
+  threads << client.start_async
 end
+
+threads.each(&:join)

lib/slack/real_time/concurrency/async.rb

@@ -22,19 +22,15 @@ class Socket < Slack::RealTime::Socket
 
           def start_async(client)
             Thread.new do
-              $stderr.puts "start_async: @driver = #{@driver}"
               ::Async::Reactor.run do
                 client.run_loop
               end
             end
           end
 
           def connect!
-            ::Async::Reactor.run do
-              super
-
-              run_loop
-            end
+            super
+            run_loop
           end
 
           def close
@@ -43,7 +39,7 @@ def close
           end
 
           def run_loop
-            while @driver and event = @driver.next_event
+            while @driver && @driver.next_event
               # $stderr.puts event.inspect
             end
           end
@@ -64,10 +60,9 @@ def build_tcp_options
           def build_endpoint
             endpoint = ::Async::IO::Endpoint.tcp(addr, port, build_tcp_options)
             endpoint = ::Async::IO::SSLEndpoint.new(endpoint, build_ssl_context) if secure?
-
-            return endpoint
+            endpoint
           end
-          
+
           def connect
             @driver = Client.new(build_endpoint.connect, url)
           end

spec/spec_helper.rb

@@ -1,7 +1,7 @@
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..'))
 
 require 'rubygems'
-require 'rspec'
+Bundler.require
 
 require 'slack-ruby-client'