Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to Web API files_list #301

Closed
wants to merge 2 commits into from
Closed

Add pagination to Web API files_list #301

wants to merge 2 commits into from

Conversation

rangerscience
Copy link

See: #299

@rangerscience rangerscience mentioned this pull request Oct 18, 2019
Open
@rangerscience
Copy link
Author

rangerscience commented Oct 18, 2019 •
edited
Loading

I didn't see any tests for pagination that I felt like I could adapt to test this code; there's
https://github.com/slack-ruby/slack-ruby-client/blob/2175a0249225a3d88c81d3b90b0d126c220728e7/spec/slack/web/api/endpoints/custom_specs/users_spec.rb#L15-22
but I don't think I can set up something to VCR for this.

@dangerpr-bot
Copy link

dangerpr-bot commented Oct 18, 2019 •
edited
Loading

1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code. 
* [#299](https://github.com/slack-ruby/slack-ruby-client/issues/299): files_list does not paginate - [@rangerscience](https://github.com/rangerscience)

Generated by 🚫 danger

dblock
dblock requested changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by a Rake task, and is not the right place to make this change. Please see #299 (comment) for an explanation.

CHANGELOG.md
@@ -3,6 +3,7 @@
* [#293](https://github.com/slack-ruby/slack-ruby-client/pull/293): Rubocop auto-correct and comprehensive todo - [@jcraigk](https://github.com/jcraigk).
* [#297](https://github.com/slack-ruby/slack-ruby-client/pull/297): Various Rubocop fixes - [@jcraigk](https://github.com/jcraigk).
* [#298](https://github.com/slack-ruby/slack-ruby-client/pull/298): Add `admin.apps`, `admin.app.requests` and `views` endpoints - [@jmanian](https://github.com/jmanian).
* [#299](https://github.com/slack-ruby/slack-ruby-client/issues/299): files_list does not paginate - [@rangerscience](https://github.com/rangerscience)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danger is complaining that the text doesn't start with a capital letter, so make it "Added pagination support to file_list."

@dblock dblock force-pushed the master branch 3 times, most recently from 6e32e8f to 0d0514f Compare June 29, 2020 12:45
@dblock
Copy link
Collaborator

dblock commented Jan 28, 2021

This API does not paginate like other APIs and takes a page and a count parameter, so it will need a different implementation.

@dblock dblock closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rangerscience @dangerpr-bot @dblock