feat: consolidate to pyproject.toml #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
approved these changes
Feb 20, 2024
| @@ -1,3 +0,0 @@ | |||
| [flake8] | |||
| exclude = .gitignore,venv | |||
There was a problem hiding this comment.
Just checking that this is alright to exclude too? I don't find any linter errors with it gone, even with my .venv so it seems okay to me
There was a problem hiding this comment.
Unfortunately Flake8 does not exclude the virtual env folders, the dev must exclude them manually based on what they named the folders .env .venv venv etc..
This is why the readme informs the users to use flake8 *.py && flake8 listeners/ to lint the project
.flake8
Outdated
There was a problem hiding this comment.
Darn that flake8 doesn't support pyproject.toml yet 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change (place an x in the [ ] that applies)
Summary
The python community is slowly recommending to use the
pyproject.tomlto configure projectsThis PR tries to consolidate the project configurations to the
pyproject.tomlRequirements (place an x in each [ ] that applies)