Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Initial commit. #1

Merged
merged 47 commits into from
Feb 1, 2023
Merged

Initial commit. #1

merged 47 commits into from
Feb 1, 2023

Conversation

technically-tracy
Copy link
Collaborator

@technically-tracy technically-tracy commented Dec 6, 2022

Type of change (place an x in the [ ] that applies)

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

A sample app example of how to use a datastore and automate the collection, storage, retrieval, and computation of data. The app includes a workflow that asks people to log the date and distance of their last run and a datastore to store everyone's runs. A second workflow prints a leaderboard to a channel, as well as weekly stats (e.g. "Your team ran X miles this week! [X% difference from last week]"). A scheduled trigger posts those stats to a channel on a weekly basis.

Requirements (place an x in each [ ] that applies)

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I love to see this sample! It's fun 😄

In addition to the comments, I'd really like to keep the language consistent, if possible and unless it's an egregious error. Admittedly, it's minor, but we want to maintain consistency as a general policy so that folks aren't taking progressive liberties with their own spin on things.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@technically-tracy technically-tracy dismissed misscoded’s stale review December 6, 2022 20:59

These changes have been made.

Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took an initial pass at the code this time. Really well done! 🎉

Let me know if you have any questions about the comments left.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
slack.json Outdated Show resolved Hide resolved
functions/display_leaderboard_function.ts Outdated Show resolved Hide resolved
functions/display_leaderboard_function.ts Outdated Show resolved Hide resolved
datastores/rundata.ts Outdated Show resolved Hide resolved
functions/display_leaderboard_function.ts Outdated Show resolved Hide resolved
manifest.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, awesome work and I love the app concept ✨ Left a few bits of feedback and some questions - will keep an eye out on this PR for updates! let me know if you have any questions 🙌

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
apps.dev.json Outdated Show resolved Hide resolved
deno.lock Show resolved Hide resolved
},
});

export default SlackFunction(FormatLeaderboardFunction, ({ inputs }) => {
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I inputted a mile amount to log for last week and no miles yet for this week and this is the leaderboard message I got:
Screenshot 2023-01-31 at 4 42 18 PM
It looks like it's calculating my miles from last week in this week's calculation, possibly because I submitted them this week?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I fully understand the case; did you log this run as happening within the past 7 days or between 8-14 days ago?

The runs are currently split between the past week (up to 7 days ago) and the prior week (8-14 days ago) when calculating the top line. I'll update the language to make it more clear that this total is for the past and prior weeks. If these days are being grouped wrong, please let me know though! I'll also give the tests another check too!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I think maybe there was some confusion with the wording! I think the date I had submitted was Jan 25 - in my mind, since that was in the last grouping of last Monday - this Sunday, it made sense as "last week". This calculation makes sense in the context of it being the last 7 days! 🙌 Thanks for the clarification!

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be in a good state to merge! Merging this and then will take public 🚀 Thanks so much for all of the hard work on this everyone!! 🙌

@hello-ashleyintech hello-ashleyintech merged commit 4d2a713 into main Feb 1, 2023
@mwbrooks mwbrooks deleted the initial-submission branch August 4, 2023 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants