Skip to content

Commit

Permalink
Merge pull request #285 from shanedewael/add-correct-logger
Browse files Browse the repository at this point in the history
Add correct logger
  • Loading branch information
Shane DeWael authored Oct 9, 2019
2 parents 31face2 + cc80f12 commit 0786683
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"url": "https://github.com/slackapi/bolt/issues"
},
"dependencies": {
"@slack/logger": "^1.0.0",
"@slack/logger": ">=1.0.0 <3.0.0",
"@slack/types": "^1.0.0",
"@slack/web-api": "^5.0.0",
"@types/express": "^4.16.1",
Expand Down
1 change: 1 addition & 0 deletions src/ExpressReceiver.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ describe('ExpressReceiver', () => {
warn(..._msg: any[]): void { },
error(..._msg: any[]): void { },
setLevel(_level: LogLevel): void { },
getLevel(): LogLevel { return LogLevel.DEBUG; },
setName(_name: string): void { },
};

Expand Down
2 changes: 2 additions & 0 deletions src/test-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ function mergeObjProperties(first: Override, second: Override): Override {

export interface FakeLogger extends Logger {
setLevel: SinonSpy<Parameters<Logger['setLevel']>, ReturnType<Logger['setLevel']>>;
getLevel: SinonSpy<Parameters<Logger['getLevel']>, ReturnType<Logger['getLevel']>>;
setName: SinonSpy<Parameters<Logger['setName']>, ReturnType<Logger['setName']>>;
debug: SinonSpy<Parameters<Logger['debug']>, ReturnType<Logger['debug']>>;
info: SinonSpy<Parameters<Logger['info']>, ReturnType<Logger['info']>>;
Expand All @@ -46,6 +47,7 @@ export function createFakeLogger(): FakeLogger {
// NOTE: the two casts are because of a TypeScript inconsistency with tuple types and any[]. all tuple types
// should be assignable to any[], but TypeScript doesn't think so.
setLevel: sinon.fake() as SinonSpy<Parameters<Logger['setLevel']>, ReturnType<Logger['setLevel']>>,
getLevel: sinon.fake() as SinonSpy<Parameters<Logger['getLevel']>, ReturnType<Logger['getLevel']>>,
setName: sinon.fake() as SinonSpy<Parameters<Logger['setName']>, ReturnType<Logger['setName']>>,
debug: sinon.fake(),
info: sinon.fake(),
Expand Down

0 comments on commit 0786683

Please sign in to comment.