Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port property to installerOptions in the HTTPReceiver #1181

Closed
srajiang opened this issue Oct 28, 2021 · 0 comments · Fixed by #1184
Closed

Add port property to installerOptions in the HTTPReceiver #1181

srajiang opened this issue Oct 28, 2021 · 0 comments · Fixed by #1184
Assignees
@seratch
Labels
enhancement M-T: A feature request for new functionality
Milestone
3.8.0

Comments

@srajiang
Copy link
Member

Description

The port option is not available on HTTPReceiverOptions['installerOptions'], meaning it's not supplied via regular installerOptions. As shown with #1179, this prevents users from setting up custom ports when using the SocketModeReceiver.

We should:

  • Add port option to installerOptions in HTTPReceiver
  • The port can be undefined for receivers that don't use it
  • If a port is supplied to HTTPReceiver#start(), the supplied port is used
@srajiang srajiang added the enhancement M-T: A feature request for new functionality label Oct 28, 2021
@srajiang srajiang added this to the 3.8.0 milestone Oct 28, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Oct 29, 2021
@seratch
Fix slackapi#1181 Add port property to installerOptions in the HTTPRe…
2890cd2 
…ceiver
@seratch seratch mentioned this issue Oct 29, 2021
Merged
2 tasks
seratch added a commit to seratch/bolt-js that referenced this issue Oct 29, 2021
@seratch
Fix slackapi#1181 Add port property to installerOptions in the HTTPRe…
871bf1c 
…ceiver
seratch added a commit to seratch/bolt-js that referenced this issue Oct 29, 2021
@seratch
Fix slackapi#1181 Add port property to installerOptions in the HTTPRe…
bd1f71f 
…ceiver
seratch added a commit that referenced this issue Oct 29, 2021
@seratch
Fix #1181 Add port property to installerOptions in the HTTPReceiver (#…
1b450f6 
…1184)
@seratch seratch self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Fix #1181 Add port property to installerOptions in the HTTPReceiver seratch/bolt-js
2 participants
@seratch @srajiang