Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors from calling say() utility cannot be handled using global error handler #183

Closed
3 tasks done
aoberoi opened this issue May 6, 2019 · 0 comments · Fixed by #184
Closed
3 tasks done

Errors from calling say() utility cannot be handled using global error handler #183

aoberoi opened this issue May 6, 2019 · 0 comments · Fixed by #184
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@aoberoi
Copy link
Contributor

aoberoi commented May 6, 2019

Description

When an error occurs while calling the say() utility function inside a listener (or a middleware), the error goes unhandled and reaches the top level of the program. This not only produces ugly console output, but is dangerous because it can cause the program to terminate.

The most thorough description of this bug is in #175. The same issue is also discussed in #176.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label May 6, 2019
aoberoi added a commit to aoberoi/bolt that referenced this issue May 6, 2019
@aoberoi
adds tests for say(), including one that fails because of issue slack…
d126b0b 
…api#183
@aoberoi aoberoi mentioned this issue May 6, 2019
Merged
2 tasks
@barlock barlock mentioned this issue Mar 16, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bind this for rejection handling from say utility aoberoi/bolt
1 participant
@aoberoi