Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @slack/web-api dependency #334

Closed
3 tasks done
aoberoi opened this issue Dec 9, 2019 · 1 comment
Closed
3 tasks done

Update @slack/web-api dependency #334

aoberoi opened this issue Dec 9, 2019 · 1 comment
Assignees
Labels
enhancement M-T: A feature request for new functionality

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Dec 9, 2019

Description

The current version specifier, ^5.2.1, is technically correct. However, there are a number of features added since then that would be useful to most developers.

If you installed Bolt a while ago and want to update, npm update won't help because it only looks for new versions of direct dependencies (not transitive dependencies like @slack/web-api). The alternative is to do rm -rf node_modules && rm package-lock.json && npm install. It's not the worst thing in the world, but its also not worth getting confused over when a feature is missing. The only cost I can see is that if the app takes a direct dependency on @slack/web-api (a minority use case), then and the version the app has chosen doesn't resolve for the version in Bolt (a super minority case), then you end up with two versions in the dependency tree - which just means the npm install operation takes marginally more time and with marginally more disk space.

Let's update it to the latest, which at this point is ^5.6.0.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the enhancement M-T: A feature request for new functionality label Dec 9, 2019
@stevengill stevengill self-assigned this Dec 10, 2019
stevengill added a commit to stevengill/bolt that referenced this issue Dec 10, 2019
stevengill added a commit that referenced this issue Dec 10, 2019
Updated web-api dependency to 5.6.0. #334
@stevengill
Copy link
Member

Fixed in #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants