Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint Config Migration: Tweak the operator-linebreak lint rule #1037

Merged
merged 1 commit into from
Aug 23, 2021
Merged

ESLint Config Migration: Tweak the operator-linebreak lint rule #1037

merged 1 commit into from
Aug 23, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 5, 2021 •
edited
Loading

Summary

This is a PR that should be merged into #1024 and incrementally addresses #842.

This PR tweaks the operator-linebreak rule such that:

  • forbid line breaks around the = operator
  • require other operators to be at the end of the line

What do folks think?

Impact

Before

✖ 362 problems (173 errors, 189 warnings)
  76 errors and 0 warnings potentially fixable with the `--fix` option.

After

✖ 306 problems (117 errors, 189 warnings)
  20 errors and 0 warnings potentially fixable with the `--fix` option.

Requirements (place an x in each [ ])

@filmaj filmaj requested a review from misscoded August 5, 2021 13:58
@gitwave gitwave bot added the untriaged label Aug 5, 2021
@filmaj filmaj mentioned this pull request Aug 5, 2021
Merged
26 tasks
@filmaj filmaj self-assigned this Aug 9, 2021
@filmaj filmaj added the tests M-T: Testing work only label Aug 9, 2021
seratch
seratch approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be due to my preference but the updated ones is this pull request is easier to read for me.

@filmaj filmaj removed the untriaged label Aug 12, 2021
stevengill
stevengill approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is more readable! Nice

@filmaj
Tweak the operator-linebreak lint rule: forbid line breaks around the…
cfa29ef 
… = operator, and prefix for other operators to be at the end of the line.
@filmaj filmaj merged commit 4b741cc into tslint-to-eslint Aug 23, 2021
@filmaj filmaj deleted the operator-linebreak branch August 23, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

@stevengill stevengill stevengill approved these changes

@misscoded misscoded misscoded approved these changes

Assignees

@filmaj filmaj

Labels
tests M-T: Testing work only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filmaj @seratch @stevengill @misscoded