Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Config Migration: Disable max-classes-per-file rule #1054

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 9, 2021

Summary

This is a PR that should be merged into #1024 and incrementally addresses #842.

This PR disables the max-classes-per-file rule. There are many situations you would want multiple classes per file, such as a generic errors module or test files that include helper mock classes. As such, I think it would be good to turn this rule off. Alternatively, we can customize the maximum number of classes to something higher.

What do folks think?

Impact

Before

✖ 362 problems (173 errors, 189 warnings)
  76 errors and 0 warnings potentially fixable with the `--fix` option.

After

✖ 359 problems (170 errors, 189 warnings)
  76 errors and 0 warnings potentially fixable with the `--fix` option.

Requirements (place an x in each [ ])

@filmaj filmaj added the tests M-T: Testing work only label Aug 9, 2021
@filmaj filmaj self-assigned this Aug 9, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. For this project (and node-slack-sdk project too), we should disable this rule as it does not work for them at all.

@filmaj filmaj merged commit 1569dc1 into tslint-to-eslint Aug 23, 2021
@filmaj filmaj deleted the no-max-classes branch August 23, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants