Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1027 by removing unnecessary lines of code in ExpressReceiver #1076

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 24, 2021

Summary

This pull request fixes #1027

Requirements (place an x in each [ ])

@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Aug 24, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1076 (512285a) into main (0ad0e89) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 512285a differs from pull request most recent head 834a616. Consider uploading reports for the commit 834a616 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
- Coverage   68.89%   68.79%   -0.11%     
==========================================
  Files          13       13              
  Lines        1212     1208       -4     
  Branches      357      356       -1     
==========================================
- Hits          835      831       -4     
  Misses        304      304              
  Partials       73       73              
Impacted Files Coverage Δ
src/receivers/ExpressReceiver.ts 66.25% <ø> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad0e89...834a616. Read the comment docs.

@seratch seratch merged commit 02d601d into slackapi:main Aug 24, 2021
@seratch seratch deleted the issue-1027-express-receiver branch August 24, 2021 21:49
@seratch seratch self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger's been set twice
3 participants