-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #868 Add ability to use a custom express app and/or router to ExpressReceiver #1084
Conversation
…r to ExpressReceiver
Codecov Report
@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 68.73% 68.79% +0.05%
==========================================
Files 13 13
Lines 1206 1208 +2
Branches 355 359 +4
==========================================
+ Hits 829 831 +2
Misses 304 304
Partials 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for adding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What, if any, documentation additions would be needed for this? Interestingly, there seems to be some discussion at least around the router
property included in this PR on the custom routes docs - and it even says that that's been a feature since 2.1!? Something doesn't add up here...
We can update the custom routes document to use |
Summary
This pull request resolves #868. With this change, developers can easily embed Bolt app endpoints in existing Express applications.
Requirements (place an
x
in each[ ]
)