Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #674 Add tokens_revoked / app_uninstalled event supports #1328

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 23, 2022

Summary

This pull request resolves #674

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality labels Feb 23, 2022
@seratch seratch added this to the 3.10.0 milestone Feb 23, 2022
@seratch seratch self-assigned this Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1328 (7e4f39d) into main (113bbab) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
+ Coverage   72.72%   72.80%   +0.07%     
==========================================
  Files          17       17              
  Lines        1463     1467       +4     
  Branches      436      437       +1     
==========================================
+ Hits         1064     1068       +4     
  Misses        310      310              
  Partials       89       89              
Impacted Files Coverage Δ
src/App.ts 82.78% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113bbab...7e4f39d. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, LGTM! :shipit:

@srajiang srajiang merged commit 5ea31af into slackapi:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support app_uninstalled, tokens_revoked events
3 participants