Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log httpServer.close error only when defined #1369

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

sbcgua
Copy link
Contributor

@sbcgua sbcgua commented Mar 14, 2022

Summary

fix #1368
Using socketMode = true with customRoutes issues irrelevant error message on app.stop

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2022

CLA assistant check
All committers have signed the CLA.

@srajiang srajiang self-requested a review March 14, 2022 21:04
@srajiang srajiang added the enhancement M-T: A feature request for new functionality label Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1369 (fc4e5b8) into main (4288c1e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
- Coverage   72.76%   72.69%   -0.07%     
==========================================
  Files          17       17              
  Lines        1465     1465              
  Branches      436      437       +1     
==========================================
- Hits         1066     1065       -1     
  Misses        310      310              
- Partials       89       90       +1     
Impacted Files Coverage Δ
src/receivers/SocketModeReceiver.ts 87.64% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4288c1e...fc4e5b8. Read the comment docs.

@seratch seratch added this to the 3.11.0 milestone Mar 15, 2022
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this edge-case @sbcgua and thank you for the contribution. LGTM!

@srajiang srajiang merged commit ec71893 into slackapi:main Mar 15, 2022
@srajiang srajiang removed their assignment Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to shutdown the HTTP server for OAuth flow, when using sockets + customRoutes
4 participants