Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix say absence in TS for reaction_ events (ref #1473) #1476

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 3, 2022

Summary

This pull request resolves the issue mentioned at #1473 (comment)

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jun 3, 2022
@seratch seratch added this to the 3.11.2 milestone Jun 3, 2022
@seratch seratch requested a review from srajiang June 3, 2022 22:49
@seratch seratch self-assigned this Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1476 (b7e31ff) into main (a5ad6f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1476   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          18       18           
  Lines        1492     1492           
  Branches      435      435           
=======================================
  Hits         1223     1223           
  Misses        172      172           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ad6f4...b7e31ff. Read the comment docs.

@seratch seratch requested a review from filmaj June 3, 2022 23:02
@filmaj filmaj merged commit 80f78ea into slackapi:main Jun 6, 2022
@seratch seratch deleted the reaction-event-say branch June 6, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants