Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates links and adds anchors in JP and EN docs #1526

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

wongjas
Copy link
Member

@wongjas wongjas commented Jul 21, 2022

Summary

This got to be a bit bigger than I thought, so I created this PR. Mostly added anchors for the JP docs, which mimic the EN ones. Also added in the anchors in the EN docs so that they don't change moving forward if we change any headers.

Requirements (place an x in each [ ])

@wongjas wongjas requested a review from seratch July 21, 2022 06:19
@wongjas wongjas self-assigned this Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1526 (de56c36) into main (f203826) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1526   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          18       18           
  Lines        1495     1495           
  Branches      435      435           
=======================================
  Hits         1227     1227           
  Misses        172      172           
  Partials       96       96           

@seratch seratch added the docs M-T: Documentation work only label Jul 21, 2022
@seratch seratch added this to the 3.12.1 milestone Jul 21, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this!

@seratch seratch merged commit 898db4f into slackapi:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants