Fix block action detection, remove StringIndexed from action body types #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue is described in much more detail here. This PR does two things:
Removes
StringIndexed
fromSlackAction
(and the interfaces in that union).SlackAction
represents the body of an action request, and in this case the fact that each of its constituent types also had an index signature (provided byStringIndexed
) meant that the typechecker allowed unknown property names to evaluate toany
. This is working against us when we use types to describe how we manipulate or conditionally check these action bodies. We might want to removeStringIndexed
from more places in the future.Changes the
action
property lookup toactions
. This fixes the issue with detection.Fixes #163
Requirements (place an
x
in each[ ]
)