Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block action detection, remove StringIndexed from action body types #166

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Apr 24, 2019

Summary

The issue is described in much more detail here. This PR does two things:

  1. Removes StringIndexed from SlackAction (and the interfaces in that union). SlackAction represents the body of an action request, and in this case the fact that each of its constituent types also had an index signature (provided by StringIndexed) meant that the typechecker allowed unknown property names to evaluate to any. This is working against us when we use types to describe how we manipulate or conditionally check these action bodies. We might want to remove StringIndexed from more places in the future.

  2. Changes the action property lookup to actions. This fixes the issue with detection.

Fixes #163

Requirements (place an x in each [ ])

@shaydewael shaydewael merged commit 8f9245f into slackapi:master Apr 24, 2019
@shaydewael shaydewael mentioned this pull request Apr 24, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started interactive message example does not work.
2 participants