Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against node 18.x #1792

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Test against node 18.x #1792

merged 1 commit into from
Apr 1, 2023

Conversation

machisuke
Copy link
Contributor

Summary

Test against node 18.x which is the current LTS version.
https://github.com/nodejs/release#release-schedule

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #1792 (712e8ae) into main (4f9a106) will not change coverage.
The diff coverage is n/a.

❗ Current head 712e8ae differs from pull request most recent head 781ebf6. Consider uploading reports for the commit 781ebf6 to get more accurate results

@@           Coverage Diff           @@
##             main    #1792   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          18       18           
  Lines        1523     1523           
  Branches      441      441           
=======================================
  Hits         1253     1253           
  Misses        172      172           
  Partials       98       98           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch added this to the 3.12.3 milestone Apr 1, 2023
@seratch seratch added the tests M-T: Testing work only label Apr 1, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 4cfb6f7 into slackapi:main Apr 1, 2023
@machisuke machisuke deleted the add_node18 branch April 1, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants