Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes failing tests: block_actions.user.name is optional #1916

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 1, 2023

This relates to #1910 : block_actions payloads can send both a username as well as name field, depending on where the action originates from. name will be present if the action was sent from the Home tab. See the Examples on the block_actions documentation for details.

This also fixes (well, hopefully! the CI will be the judge of that) the currently-failing tests on main. On GitHub CI the build was failing because GitHub was using v2.28.0 of the eslint-import-plugin, whereas on my machine (where I could not reproduce it) was using v2.27.5.

@filmaj filmaj added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch tests M-T: Testing work only TypeScript-specific labels Aug 1, 2023
@filmaj filmaj added this to the 3.13.3 milestone Aug 1, 2023
@filmaj filmaj self-assigned this Aug 1, 2023
@filmaj
Copy link
Contributor Author

filmaj commented Aug 1, 2023

Very bizarre... unclear why I can't reproduce the lint failure locally. Using the same version of eslint, too...

@filmaj
Copy link
Contributor Author

filmaj commented Aug 1, 2023

I'm iterating on this issue on my fork here.

One thing I noticed running in debug mode locally and on GitHub CI is that the eslint-plugin-import on my machine is running 2.27.5 but 2.28.0 on GitHub CI.. maybe that's it? Gonna try.. yep that was it. Upgrading my package.json's dependencies so that eslint-plugin-import uses the latest version lets me, at least, reproduce the error locally.

Floating dependency versions are a curse!

…till be present, e.g. in Home tab actions. Fix related test, too.

Bumping eslint-plugin-import dependency, fixing up lint errors.
@filmaj filmaj force-pushed the fix-block-actions-payload-and-test branch from 9c73ef9 to 054433d Compare August 1, 2023 22:07
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1916 (e8f816f) into main (a1bc17a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head e8f816f differs from pull request most recent head 054433d. Consider uploading reports for the commit 054433d to get more accurate results

@@           Coverage Diff           @@
##             main    #1916   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           
Files Changed Coverage Δ
src/receivers/HTTPModuleFunctions.ts 80.00% <ø> (ø)
src/receivers/HTTPResponseAck.ts 93.75% <ø> (ø)
src/receivers/AwsLambdaReceiver.ts 71.42% <100.00%> (ø)
src/receivers/ExpressReceiver.ts 88.70% <100.00%> (ø)
src/receivers/HTTPReceiver.ts 59.03% <100.00%> (ø)
src/receivers/SocketModeReceiver.ts 84.61% <100.00%> (ø)
src/receivers/verify-request.ts 73.52% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@filmaj filmaj merged commit 1bae761 into main Aug 1, 2023
5 checks passed
@filmaj filmaj deleted the fix-block-actions-payload-and-test branch August 1, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch tests M-T: Testing work only TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant