Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties in app_mention event payload #2160

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 10, 2024

Summary

Refer to slackapi/bolt-python#1107 for the context

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jul 10, 2024
@seratch seratch added this to the 3.20.0 milestone Jul 10, 2024
@seratch seratch requested review from filmaj and zimeg July 10, 2024 05:17
@seratch seratch self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (4d97757) to head (6cbaec6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2160   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          18       18           
  Lines        1545     1545           
  Branches      443      443           
=======================================
  Hits         1268     1268           
  Misses        179      179           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this 🙏 The commented context and related issue is all super useful to know and all of these fields are appearing as expected in testing 🚢💨

src/types/events/base-events.ts Outdated Show resolved Hide resolved
@seratch seratch merged commit 0afa1e6 into slackapi:main Jul 10, 2024
9 checks passed
@seratch seratch deleted the app-mention branch July 10, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants