Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bold Text Rendering Issue #2183

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

suekou
Copy link
Contributor

@suekou suekou commented Aug 4, 2024

Summary

This PR aims to fix the issue with Markdown bold formatting in the documentation, specifically where bold text was not rendered correctly after punctuation marks.

Before:
image

Requirements (place an x in each [ ])

Copy link

salesforce-cla bot commented Aug 4, 2024

Thanks for the contribution! Before we can merge this, we need @suekou to sign the Salesforce Inc. Contributor License Agreement.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suekou Could you sign our CLA? Without it, we are unable to merge any external contributions.

@seratch seratch added the docs M-T: Documentation work only label Aug 4, 2024
@seratch seratch added this to the 3.20.0 milestone Aug 4, 2024
@seratch seratch self-assigned this Aug 4, 2024
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (5e6e8bd) to head (2e06dcc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          18       18           
  Lines        1545     1545           
  Branches      443      443           
=======================================
  Hits         1268     1268           
  Misses        179      179           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suekou
Copy link
Contributor Author

suekou commented Aug 5, 2024

@seratch Thank you for reviewing this. As shown in the image, I have already signed the CLA on 2024-08-04. However, it appears that GitHub Actions is not recognizing it. I'm not fully familiar with the specifications of this CLA system. Is there anything that I need to do after signing the CLA?
image

@seratch
Copy link
Member

seratch commented Aug 5, 2024

@suekou The email address you used for the commit could be different. Can you double-check if the address is the same with CLA signing?

@suekou
Copy link
Contributor Author

suekou commented Aug 5, 2024

@seratch
I double-checked and confirmed that the email address is indeed the same as the one used for signing the CLA. However, one possibility that comes to mind is that I encountered an error during the signing process, but the sign-off appeared to be completed after I reloaded the page. It's possible that a bug occurred at that point. Just to clarify, there's no need for users to manually rerun actions after signing the CLA, right?
Since it is difficult for me to resolve this issue on my end, I would appreciate it if you could close this PR and make the necessary corrections on your behalf. Thank you!

@hello-ashleyintech
Copy link
Contributor

closed PR and re-opened so CLA check would re-run - looks like it's seeing the signed CLA now!

@seratch seratch merged commit a455807 into slackapi:main Aug 6, 2024
11 checks passed
@suekou
Copy link
Contributor Author

suekou commented Aug 6, 2024

@hello-ashleyintech Thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants