Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove please-upgrade-node #2221

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: remove please-upgrade-node #2221

merged 1 commit into from
Aug 28, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 28, 2024

fixes #1274

Instead of pulling in an extra dependency to massage node version incompatibilities, I say we just rely on the node/npm tooling (in particular: the engines property of package.json) to do that work for us. Would help us in fixing issues like #1274 (people using weird bundlers and deploying to constrained runtimes).

@filmaj filmaj added enhancement M-T: A feature request for new functionality semver:patch labels Aug 28, 2024
@filmaj filmaj added this to the 3.21.2 milestone Aug 28, 2024
@filmaj filmaj requested a review from a team August 28, 2024 17:31
@filmaj filmaj self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (ffabf3c) to head (2910194).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2221   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files          19       19           
  Lines        1646     1646           
  Branches      464      464           
=======================================
  Hits         1343     1343           
  Misses        194      194           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Nice find - one less dependency always a good feeling! I also agree that this is a task for the engines 🚂 💨

@filmaj filmaj merged commit 06f6efb into main Aug 28, 2024
15 checks passed
@filmaj filmaj deleted the axe-upgrade-node branch August 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PleaseUpgradeNode issues with NCC/Webpack
2 participants