Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #221 Allow custom WebClient options #228

Merged
merged 6 commits into from
Oct 4, 2019
Merged

Fix for #221 Allow custom WebClient options #228

merged 6 commits into from
Oct 4, 2019

Conversation

koh110
Copy link
Contributor

@koh110 koh110 commented Aug 1, 2019

Summary

This pull request check off todo in src/App.ts.

https://github.com/slackapi/bolt/blob/9ac97de32d45002a95e414922fc523f132efeb98/src/App.ts#L136

I want to use options such as proxy for security.
So, I did this todo.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #228 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #228     +/-   ##
=========================================
+ Coverage   61.94%   62.24%   +0.3%     
=========================================
  Files           7        7             
  Lines         494      498      +4     
  Branches      136      138      +2     
=========================================
+ Hits          306      310      +4     
  Misses        163      163             
  Partials       25       25
Impacted Files Coverage Δ
src/App.ts 71.6% <100%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b030f27...ff5b944. Read the comment docs.

@koh110
Copy link
Contributor Author

koh110 commented Aug 1, 2019

Oops, I overlooked this issue is In Progress.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@seratch seratch changed the title Pass webclient options Fix for #221 Allow custom WebClient options Aug 14, 2019
@shaydewael shaydewael merged commit 37ce0d3 into slackapi:master Oct 4, 2019
@aoberoi aoberoi mentioned this pull request Oct 4, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants