-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #221 Allow custom WebClient options #228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=========================================
+ Coverage 61.94% 62.24% +0.3%
=========================================
Files 7 7
Lines 494 498 +4
Branches 136 138 +2
=========================================
+ Hits 306 310 +4
Misses 163 163
Partials 25 25
Continue to review full report at Codecov.
|
Oops, I overlooked this issue is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Summary
This pull request check off todo in src/App.ts.
https://github.com/slackapi/bolt/blob/9ac97de32d45002a95e414922fc523f132efeb98/src/App.ts#L136
I want to use options such as proxy for security.
So, I did this todo.
Requirements (place an
x
in each[ ]
)