Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor function handler for follow up auto ack behavior #2424

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented Feb 14, 2025

Summary

This PR aims to

  • Increase unit test coverage for the custom function handler
  • Align the function handler with the middleware pattern used by actions and events
  • Set up the project to allow simple introduction of auto acknowledgment flag

Manual tests

These changes were manually tested against

bolt-js-custom-step-template -> no breaking change observed 🟢
bolt-ts-starter-template -> no breaking change observed 🟢

Requirements

@WilliamBergamin WilliamBergamin added enhancement M-T: A feature request for new functionality semver:minor labels Feb 14, 2025
@WilliamBergamin WilliamBergamin self-assigned this Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 94.40000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (82ab164) to head (8422fff).

Files with missing lines Patch % Lines
src/App.ts 89.09% 5 Missing and 1 partial ⚠️
src/CustomFunction.ts 98.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2424      +/-   ##
==========================================
+ Coverage   92.59%   92.92%   +0.32%     
==========================================
  Files          36       36              
  Lines        7472     7410      -62     
  Branches      653      653              
==========================================
- Hits         6919     6886      -33     
+ Misses        545      519      -26     
+ Partials        8        5       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin WilliamBergamin marked this pull request as ready for review February 17, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant