Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release @slack/bolt@4.2.1 #2433

Merged
merged 2 commits into from
Feb 28, 2025
Merged

chore: release @slack/bolt@4.2.1 #2433

merged 2 commits into from
Feb 28, 2025

Conversation

WilliamBergamin
Copy link
Contributor

Summary

Release @slack/bolt@4.2.1

Requirements

@@ -64,7 +64,7 @@ Releasing can feel intimidating at first, but rest assured: if you make a mistak

3. Bump the version number in adherence to [Semantic Versioning](http://semver.org/) in `package.json`. (see [Versioning and Tags](https://github.com/slackapi/node-slack-sdk/blob/main/.github/maintainers_guide.md#versioning-and-tags))
- The version must be in the format of `Major.Minor.Patch-BetaNamespace.BetaVersion` (ex: `5.10.0-workflowStepsBeta.1`, `2.5.0-rc.1`)
- Update any dependency versions in `package.json` and install locally `rm -rf node_modules && npm install`
- Update any dependency versions in `package.json` and install locally `rm -r node_modules package-lock.json && npm install`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rf is not needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-r is to remove files in a directory recessively, -rf is to force remove files recessively, the force flag brings additional risk of accidentally deleting something important if you run this command in the wrong directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yeah, I was wondering if users would run into permission errors with deleting if we had guidance to use -r only vs. -rf. but we can always add it back if needed! I agree to go with the less destructive command as guidance

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (11ae5c9) to head (e0025d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2433   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@WilliamBergamin WilliamBergamin merged commit 3e035ae into main Feb 28, 2025
18 checks passed
@WilliamBergamin WilliamBergamin deleted the @slack/bolt@4.2.1 branch February 28, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants