Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In "updating modals" code example, ove 'type' to be nested inside 'view' #318

Merged
merged 3 commits into from
Nov 27, 2019

Conversation

yamashush
Copy link
Contributor

Summary

To fix the issue described in #317

It looks like the example on https://slack.dev/bolt/concepts#updating-pushing-views has type at the top level object but it should actually be nested in view as shown in https://api.slack.com/reference/block-kit/views

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failures seem to be unrelated. Looks good to me.

Good catch, thanks 👍

@seratch
Copy link
Member

seratch commented Nov 25, 2019

After merging #321 and rebasing onto master, we'll be able to merge this.

@seratch seratch self-assigned this Nov 25, 2019
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files           7        7           
  Lines         506      506           
  Branches      145      145           
=======================================
  Hits          373      373           
  Misses        101      101           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6aa800...4e9d9a3. Read the comment docs.

@seratch
Copy link
Member

seratch commented Nov 27, 2019

Finally, the CI builds are successful 😌
@yamashush good catch! Thanks again 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants