Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire im_open event for the bot #331

Closed
wants to merge 1 commit into from
Closed

Fire im_open event for the bot #331

wants to merge 1 commit into from

Conversation

TK95
Copy link
Contributor

@TK95 TK95 commented Dec 8, 2019

Summary

This PR partially relates to #236.

Consider the use case:
Show a list of supported slash commands, messages, etc when the user opens IM with the bot for the very first time.

In order to implement that, you have to subscribe to the im_open event, but this event isn't fired for your bot.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Dec 8, 2019

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files           7        7           
  Lines         506      506           
  Branches      145      145           
=======================================
  Hits          373      373           
  Misses        101      101           
  Partials       32       32
Impacted Files Coverage Δ
src/middleware/builtin.ts 68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9cbaf...9397a95. Read the comment docs.

@TK95
Copy link
Contributor Author

TK95 commented Dec 11, 2019

It looks like, it's better to utilize the app_hope_opened event, it's fired whenever you open DM with your bot.

Closing PR.

@TK95 TK95 closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant