Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Specifies view submission response action types (#404) #411

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 17, 2020

Summary

This pull request brings the great #404 change by @aoberoi to the @slack/bolt@next branch (=v2 trunk branch).

Requirements (place an x in each [ ])

* specifies view submission response action types for use in .view() listener acks
* fixes view submission state by adding values property
@seratch seratch added the enhancement M-T: A feature request for new functionality label Feb 17, 2020
@seratch seratch added this to the V2 milestone Feb 17, 2020
@seratch seratch self-assigned this Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #411 into @slack/bolt@next will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #411   +/-   ##
=================================================
  Coverage             85.37%   85.37%           
=================================================
  Files                     7        7           
  Lines                   506      506           
  Branches                144      144           
=================================================
  Hits                    432      432           
  Misses                   49       49           
  Partials                 25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ca14a...2fbcb95. Read the comment docs.

@stevengill stevengill merged commit d66b09e into slackapi:@slack/bolt@next Feb 18, 2020
@seratch seratch deleted the v2-pr-404 branch June 20, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants