Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix #405 by providing a better way to configure logger #413

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 18, 2020

Summary

This pull request brings the changes by #406 (fixes #405) to the v2 branch.

Requirements (place an x in each [ ])

@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Feb 18, 2020
@seratch seratch self-assigned this Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #413 into @slack/bolt@next will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           @slack/bolt@next     #413      +/-   ##
====================================================
+ Coverage             85.37%   85.51%   +0.14%     
====================================================
  Files                     7        7              
  Lines                   506      511       +5     
  Branches                144      146       +2     
====================================================
+ Hits                    432      437       +5     
  Misses                   49       49              
  Partials                 25       25              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3400479...d1a03fa. Read the comment docs.

@seratch seratch merged commit 1428ec3 into slackapi:@slack/bolt@next Feb 19, 2020
@seratch seratch deleted the pr-406-v2 branch February 19, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant